xfs
[Top] [All Lists]

[PATCH] xfs_repair: inode flags check should use flags

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfs_repair: inode flags check should use flags
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 24 Feb 2011 09:29:11 +1100
Cc: aelder@xxxxxxx
From: Dave Chinner <dchinner@xxxxxxxxxx>

The RT bitmap inode format flag check should use the flag, not the
bit definition. As a result, it is incorrectly detecting inodes with
the prealloc flag set as has having an invalid bit set.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>
---
 repair/dinode.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/repair/dinode.c b/repair/dinode.c
index fad15b2..3a092e4 100644
--- a/repair/dinode.c
+++ b/repair/dinode.c
@@ -2551,11 +2551,11 @@ process_dinode_int(xfs_mount_t *mp,
                                                XFS_DIFLAG_RTINHERIT);
                        }
                }
-               if (flags & XFS_DIFLAG_NEWRTBM_BIT) {
+               if (flags & XFS_DIFLAG_NEWRTBM) {
                        /* must be a rt bitmap inode */
                        if (lino != mp->m_sb.sb_rbmino) {
                                do_warn(_("inode %llu not rt bitmap"), lino);
-                               flags &= ~XFS_DIFLAG_NEWRTBM_BIT;
+                               flags &= ~XFS_DIFLAG_NEWRTBM;
                        }
                }
                if (flags & (XFS_DIFLAG_RTINHERIT |
-- 
1.7.2.3

<Prev in Thread] Current Thread [Next in Thread>