[Top] [All Lists]

Re: [PATCH 2/2] xfs: more sensible inode refcounting for ialloc

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: more sensible inode refcounting for ialloc
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 22 Feb 2011 19:52:40 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110213132642.GB18279@xxxxxxxxxxxxx>
References: <20110213132642.GB18279@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Sun, 2011-02-13 at 08:26 -0500, Christoph Hellwig wrote:
> Currently we return iodes from xfs_ialloc with just a single reference held.
> But we need two references, as one is dropped during transaction commit and
> the second needs to be transfered to the VFS.  Change xfs_ialloc to use
> xfs_iget plus xfs_trans_ijoin_ref to grab two references to the inode,
> and remove the now superflous IHOLD calls from all callers.  This also
> greatly simplifies the error handling in xfs_create and also allow to remove
> xfs_trans_iget as no other callers are left.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

So the first inode reference we get is the one that
gets handed back to the VFS.  The second reference is
for the transaction, and it's now added precisely
at the point at which the inode is joined to the
transaction.  Nice.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>