xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: stop using xfs_trans_iget in the RT allocator

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: stop using xfs_trans_iget in the RT allocator
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 23 Feb 2011 11:49:46 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110213132531.GA18279@xxxxxxxxxxxxx>
References: <20110213132531.GA18279@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Sun, Feb 13, 2011 at 08:25:31AM -0500, Christoph Hellwig wrote:
> During mount we establish references to the RT inodes, which we keep for
> the lifetime of the filesystem.  Instead of using xfs_trans_iget to grab
> additional references when adding RT inodes to transactions use the
> combination of xfs_ilock and xfs_trans_ijoin_ref, which archives the same
                                                          achieves
> end result with less overhead.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>