xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: validate inode di_flaaags field

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfs_repair: validate inode di_flaaags field
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 22 Feb 2011 15:39:05 -0600
Cc: Dave Chinner <dchinner@xxxxxxxxxx>
In-reply-to: <1298407556.1960.54.camel@doink>
References: <1298407419.1960.48.camel@doink> <1298407556.1960.54.camel@doink>
Reply-to: aelder@xxxxxxx
On Tue, 2011-02-22 at 14:45 -0600, Alex Elder wrote:
> On Tue, 2011-02-22 at 14:43 -0600, Alex Elder wrote:
> > (I may have missed it, but I don't believe Dave posted
> > this patch so I'm doing it for him to get it on the
> > list.  -Alex)
> > 
> > xfs-reapir is not validating the di_flags field in the inode for
> > sanity. Block fuzzing indicates that we are not picking situations
> > like the RT bit being set on filesystems without realtime devices.
> >     
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Turns out this was on the list, it just was sent as a
"will you please try this patch" message on the subject
of "XFS internal error xfs_iformat(realtime) even after
xfs_repair."


Anyway, now I've reviewed it, and it looks good.  The
typo's in the subject line and in the description ought
to be fixed before it's committed.

Reviewed-by: Alex Elder <aelder@xxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>