[Top] [All Lists]

Re: [PATCH] xfsprogs: Don't ever try to set the device blocksize in repa

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: Don't ever try to set the device blocksize in repair
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 22 Feb 2011 14:04:19 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4D62B7D1.4040901@xxxxxxxxxx>
References: <4D62B7D1.4040901@xxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Mon, 2011-02-21 at 13:06 -0600, Eric Sandeen wrote:
> On 4k devices, we get this warning from repair:
> # xfs_repair /dev/sdc2
> xfs_repair: warning - cannot set blocksize 512 on block device /dev/sdc2: 
> Invalid argument
> Phase 1 - find and verify superblock...
> ...
> but things proceed without trouble after that.
> I'm unable to find any history or reason for setting the
> device blocksize at the beginning of repair, and in any case,
> things clearly work without doing so.  So, let's just remove it.
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

On Linux anyway, the way it's used here is pretty
pointless anyway.  It passes either 0 or 1, which
means either don't set it (if "living dangerously")
or do set it, to the minimum XFS sector size, 512
bytes.  Hence it'll screw up on > 512-byte sector

If there was a reason for setting it, it should
do so by setting it to the device's logical block
size rather than assuming 512.

But I don't see a reason to set it either, so the
change looks good to me.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>