xfs
[Top] [All Lists]

[XFS updates] XFS development tree branch, master, updated. v2.6.37-rc4-

To: xfs@xxxxxxxxxxx
Subject: [XFS updates] XFS development tree branch, master, updated. v2.6.37-rc4-9183-g5d15765
From: xfs@xxxxxxxxxxx
Date: Tue, 22 Feb 2011 12:40:36 -0600
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, master has been updated
  5d15765 xfs: check if device support discard in xfs_ioc_trim()
  c4d0c3b xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1
      from  9681153b460006923bb1e9d39b05b80ec09d6b4e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5d15765594eeb5d82c5630b3428ea0ac4f7d3c31
Author: Lukas Czerner <lczerner@xxxxxxxxxx>
Date:   Tue Feb 15 17:07:36 2011 +0000

    xfs: check if device support discard in xfs_ioc_trim()
    
    Right now we, are relying on the fact that when we attempt to
    actually do the discard, blkdev_issue_discar() returns -EOPNOTSUPP
    and the user is informed that the device does not support discard.
    
    However, in the case where the we do not hit any suitable free
    extent to trim in FITRIM code, it will finish without any error.
    This is very confusing, because it seems that FITRIM was successful
    even though the device does not actually supports discard.
    
    Solution: Check for the discard support before attempt to search for
    free extents.
    
    Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
    Signed-off-by: Alex Elder <aelder@xxxxxxx>

commit c4d0c3b097f7584772316ee4d64a09fe0e4ddfca
Author: Dan Rosenberg <drosenberg@xxxxxxxxxxxxx>
Date:   Mon Feb 14 13:45:28 2011 +0000

    xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1
    
    The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to
    xfs_fs_geometry() with a version number of 3.  This code path does not
    fill in the logsunit member of the passed xfs_fsop_geom_t, leading to
    the leaking of four bytes of uninitialized stack data to potentially
    unprivileged callers.
    
    v2 switches to memset() to avoid future issues if structure members
    change, on suggestion of Dave Chinner.
    
    Signed-off-by: Dan Rosenberg <drosenberg@xxxxxxxxxxxxx>
    Reviewed-by: Eugene Teo <eugeneteo@xxxxxxxxxx>
    Signed-off-by: Alex Elder <aelder@xxxxxxx>

-----------------------------------------------------------------------

Summary of changes:
 fs/xfs/linux-2.6/xfs_discard.c |    2 ++
 fs/xfs/xfs_fsops.c             |    3 +++
 2 files changed, 5 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
XFS development tree

<Prev in Thread] Current Thread [Next in Thread>
  • [XFS updates] XFS development tree branch, master, updated. v2.6.37-rc4-9183-g5d15765, xfs <=