xfs
[Top] [All Lists]

Re: [PATCH] Check for immutable flag in fallocate path

To: Marco Stornelli <marco.stornelli@xxxxxxxxx>
Subject: Re: [PATCH] Check for immutable flag in fallocate path
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 21 Feb 2011 07:46:35 -0500
Cc: Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, cluster-devel@xxxxxxxxxx, Linux FS Devel <linux-fsdevel@xxxxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <4D6221B8.9040303@xxxxxxxxx>
References: <4D6221B8.9040303@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Feb 21, 2011 at 09:26:32AM +0100, Marco Stornelli wrote:
> From: Marco Stornelli <marco.stornelli@xxxxxxxxx>
> 
> All fs must check for the immutable flag in their fallocate callback.
> It's possible to have a race condition in this scenario: an application
> open a file in read/write and it does something, meanwhile root set the
> immutable flag on the file, the application at that point can call
> fallocate with success. Only Ocfs2 check for the immutable flag at the
> moment.

Please add the check in fs/open.c:do_fallocate() so that it covers all
filesystems.

<Prev in Thread] Current Thread [Next in Thread>