xfs
[Top] [All Lists]

[PATCH] Check for immutable flag in fallocate path

To: Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>
Subject: [PATCH] Check for immutable flag in fallocate path
From: Marco Stornelli <marco.stornelli@xxxxxxxxx>
Date: Mon, 21 Feb 2011 09:26:32 +0100
Cc: linux-ext4@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, xfs@xxxxxxxxxxx, Linux FS Devel <linux-fsdevel@xxxxxxxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:content-type:content-transfer-encoding; bh=jSNmQq33dDOeIbF+1OfmWMXY7U6KcIEZ/+abW39q2m8=; b=qRX+crg1dBfyxQ4QlClSFaxEBE1YblID7+SoJvwg6RcKTPIlBONtL+DzuMTO8555Rm UlZBCQqI026CXQFxJw54x0/cQSaffjpD5fEbgXtHQKEJ578uFirURZtMkx5UZoYYw/nK XyTgsEblzWF6+FeFQBo/zkSG+H2BRi1UUuXQk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=Sel2ZBvT5fwGWvXiokj0R3KdY0ji0vZjaeN62+tIlhgOxcrvMPrxCYeMlZdkTL+GmP wa7cD9bsYr7XiPS4IfSZjo1cpkO7Omj95lteLR30wCX7eBrWicleUQsP0lZZxW04moa8 Y24eV2c6rJ9amZhPmR2g24O1Ztk4ocBfr/UiI=
User-agent: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11
From: Marco Stornelli <marco.stornelli@xxxxxxxxx>

All fs must check for the immutable flag in their fallocate callback.
It's possible to have a race condition in this scenario: an application
open a file in read/write and it does something, meanwhile root set the
immutable flag on the file, the application at that point can call
fallocate with success. Only Ocfs2 check for the immutable flag at the
moment.

Signed-off-by: Marco Stornelli <marco.stornelli@xxxxxxxxx>
---
Patch is against 2.6.38-rc5

--- linux-2.6.38-rc5-orig/fs/ext4/extents.c     2011-02-16 04:23:45.000000000 
+0100
+++ linux-2.6.38-rc5/fs/ext4/extents.c  2011-02-21 08:43:37.000000000 +0100
@@ -3670,6 +3670,12 @@ long ext4_fallocate(struct file *file, i
         */
        credits = ext4_chunk_trans_blocks(inode, max_blocks);
        mutex_lock(&inode->i_mutex);
+
+       if (IS_IMMUTABLE(inode)) {
+               mutex_unlock(&inode->i_mutex);
+               return -EPERM;
+       }
+
        ret = inode_newsize_ok(inode, (len + offset));
        if (ret) {
                mutex_unlock(&inode->i_mutex);
--- linux-2.6.38-rc5-orig/fs/btrfs/file.c       2011-02-16 04:23:45.000000000 
+0100
+++ linux-2.6.38-rc5/fs/btrfs/file.c    2011-02-21 08:55:58.000000000 +0100
@@ -1289,6 +1289,12 @@ static long btrfs_fallocate(struct file
        btrfs_wait_ordered_range(inode, alloc_start, alloc_end - alloc_start);
 
        mutex_lock(&inode->i_mutex);
+
+       if (IS_IMMUTABLE(inode)) {
+               ret = -EPERM;
+               goto out;
+       }
+
        ret = inode_newsize_ok(inode, alloc_end);
        if (ret)
                goto out;
--- linux-2.6.38-rc5-orig/fs/xfs/linux-2.6/xfs_file.c   2011-02-16 
04:23:45.000000000 +0100
+++ linux-2.6.38-rc5/fs/xfs/linux-2.6/xfs_file.c        2011-02-21 
09:07:46.000000000 +0100
@@ -909,6 +909,11 @@ xfs_file_fallocate(
        if (mode & FALLOC_FL_PUNCH_HOLE)
                cmd = XFS_IOC_UNRESVSP;
 
+       if (IS_IMMUTABLE(inode)) {
+               error = -EPERM;
+               goto out_unlock;
+       }
+
        /* check the new inode size is valid before allocating */
        if (!(mode & FALLOC_FL_KEEP_SIZE) &&
            offset + len > i_size_read(inode)) {
--- linux-2.6.38-rc5-orig/fs/gfs2/file.c        2011-02-16 04:23:45.000000000 
+0100
+++ linux-2.6.38-rc5/fs/gfs2/file.c     2011-02-21 09:09:17.000000000 +0100
@@ -797,6 +797,11 @@ static long gfs2_fallocate(struct file *
        if (unlikely(error))
                goto out_uninit;
 
+       if (IS_IMMUTABLE(inode)) {
+               error = -EPERM;
+               goto out_unlock;
+       }
+
        if (!gfs2_write_alloc_required(ip, offset, len))
                goto out_unlock;
 

<Prev in Thread] Current Thread [Next in Thread>