xfs
[Top] [All Lists]

Re: [PATCH V3] xfs_quota: don't try to report quotas which aren't there.

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH V3] xfs_quota: don't try to report quotas which aren't there.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 21 Feb 2011 08:16:31 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4D5EB423.9040009@xxxxxxxxxx>
References: <4D5EB09A.3030605@xxxxxxxxxx> <4D5EB27C.3070306@xxxxxxxxxx> <4D5EB423.9040009@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Feb 18, 2011 at 12:02:11PM -0600, Eric Sandeen wrote:
> Red Hat bug #669333 - xfs_quota generates "XFS_GETQUOTA: No such process" 
> errors
> shows that if you do this for a filesystem w/o group quota enabled:
> 
> # xfs_quota -x -c ' report -h ' /xfsquota"
> 
> You'll get this output:
> 
> User quota on /xfsquota (/dev/vdb)
>                         Blocks              
> User ID      Used   Soft   Hard Warn/Grace   
> ---------- --------------------------------- 
> root            0      0      0  00 [------]
> 
> XFS_GETQUOTA: No such process
> XFS_GETQUOTA: No such process
> ...
> 
> because we're calling XFS_GETQUOTA for types which aren't enabled.
> 
> The below patch fixes it for me, just ignoring types that aren't
> there.
> 
> V2: Thanks to Arkadiusz Miskiewicz for pointing out the simpler fix.
> V3: Thanks again to Arkadiusz for suggesting fixing dump as well
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks sane.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>