xfs
[Top] [All Lists]

Re: [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 14 Feb 2011 16:46:22 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110214051005.GI2559@dastard>
References: <1294649091-27174-1-git-send-email-david@xxxxxxxxxxxxx> <1294649091-27174-3-git-send-email-david@xxxxxxxxxxxxx> <1297288144.2513.228.camel@doink> <20110214051005.GI2559@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Feb 14, 2011 at 04:10:05PM +1100, Dave Chinner wrote:
> On Wed, Feb 09, 2011 at 03:49:03PM -0600, Alex Elder wrote:
> > On Mon, 2011-01-10 at 19:44 +1100, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > > 
> > > Update libxlog with the current 2.6.38 kernel code and well as
> > > updating the necessary parts of libxfs and variaous header files to
> > > ensure that it compiles correctly.

....

> > > diff --git a/libxfs/xfs_mount.c b/libxfs/xfs_mount.c
> > > index 02bff42..dde9678 100644
> > > --- a/libxfs/xfs_mount.c
> > > +++ b/libxfs/xfs_mount.c
> > > @@ -270,7 +270,6 @@ xfs_mount_common(xfs_mount_t *mp, xfs_sb_t *sbp)
> > >   mp->m_blockmask = sbp->sb_blocksize - 1;
> > >   mp->m_blockwsize = sbp->sb_blocksize >> XFS_WORDLOG;
> > >   mp->m_blockwmask = mp->m_blockwsize - 1;
> > > - INIT_LIST_HEAD(&mp->m_del_inodes);
> > 
> > This hunk belongs in the next patch, not this one.
> > 
> 
> OK.

Actually, it has to be in this patch, because the only reason it
compiled prior to this patch was that INIT_LIST_HEAD() was defined
to a null macro. It is actually implemented in this patch, so this
does need to be removed here or the patch won't compile....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>