xfs
[Top] [All Lists]

Re: [GIT PULL] XFS update for 2.6.38-rc3

To: xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [GIT PULL] XFS update for 2.6.38-rc3
From: Arkadiusz Miskiewicz <a.miskiewicz@xxxxxxxxx>
Date: Thu, 3 Feb 2011 23:02:31 +0100
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Mark Lord <kernel@xxxxxxxxxxxx>, Alex Elder <aelder@xxxxxxx>, stable@xxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; bh=1lx/3NysiaUL26u0OK92WhOEr5RxuDHjGG+DULHUcbw=; b=PKWXkP79WL9a/lVmN34kXZNlOFWUpqJtnB2fA/PvfbZaCoDIKumMVryBcXmHrvVHYc ojC7Nsvx2zATfUELzLbThr39NrSa/VwNNBQhjM+O0F7x4eL92ALxNFsRjdVNfmUOOdGf QBKit7wgTcKACPFnbf45DT06n0e3PAJDDnhRQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=I9KjeCWqk3tfaVtC+/iFvyaPFE1VGUIJ/msdpy6+oy5yFNHr9QsXSr7AJlBmBc0ssM bmsR3Ct7ArXPEOqcUx5g5S8spwaYpzIPFp3ld7oYLLlEDzpeKjI5ZsHfT/MrrAJV6Ked M2fnsU59yRn18uTZDIsqEQFp964cfFeqmypVI=
In-reply-to: <20110203000757.GT11040@dastard>
References: <201101311642.p0VGgXTS018851@xxxxxxxxxxxxxxxxxxxxxx> <4D482E21.5040803@xxxxxxxxxxxx> <20110203000757.GT11040@dastard>
User-agent: KMail/1.13.6 (Linux/2.6.37; KDE/4.6.0; x86_64; ; )
On Thursday 03 of February 2011, Dave Chinner wrote:
> On Tue, Feb 01, 2011 at 11:00:33AM -0500, Mark Lord wrote:
> > On 11-01-31 11:42 AM, Alex Elder wrote:
> > > Linus, please accept the following updates for XFS, for 2.6.38-rc3
> > > (if it's not too late) or 2.6.38-rc4.
> > > 
> > > They are all fixes for bugs that have some pretty undesirable
> > > consequences. 

[...]

> > Are these bugs all new in 2.6.38, or should some of these fixes
> > also go out to -stable for earlier revisions?
> > >       xfs: fix dquot shaker deadlock
> 
> That's a regression, so maybe.

Definitely, xfs_fsr can hit this even few times a day (happened already).

Stable team, please include this one for 2.6.37.1:

commit 0fbca4d1c3932c27c4794bf5c2b5fc961cf5a54f
Author: Dave Chinner <dchinner@xxxxxxxxxx>
Date:   Fri Jan 28 11:20:46 2011 +1100

    xfs: fix dquot shaker deadlock

    Commit 368e136 ("xfs: remove duplicate code from dquot reclaim") fails
    to unlock the dquot freelist when the number of loop restarts is
    exceeded in xfs_qm_dqreclaim_one(). This causes hangs in memory
    reclaim.

    Rework the loop control logic into an unwind stack that all the
    different cases jump into. This means there is only one set of code
    that processes the loop exit criteria, and simplifies the unlocking
    of all the items from different points in the loop. It also fixes a
    double increment of the restart counter from the qi_dqlist_lock
    case.

    Reported-by: Malcolm Scott <lkml@xxxxxxxxxxx>
    Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
    Reviewed-by: Alex Elder <aelder@xxxxxxx>


> Cheers,
> 
> Dave.


-- 
Arkadiusz Miśkiewicz        PLD/Linux Team
arekm / maven.pl            http://ftp.pld-linux.org/

<Prev in Thread] Current Thread [Next in Thread>