xfs
[Top] [All Lists]

Re: [GIT PULL] XFS update for 2.6.38-rc3

To: Mark Lord <kernel@xxxxxxxxxxxx>
Subject: Re: [GIT PULL] XFS update for 2.6.38-rc3
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 3 Feb 2011 11:07:57 +1100
Cc: Alex Elder <aelder@xxxxxxx>, torvalds@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx
In-reply-to: <4D482E21.5040803@xxxxxxxxxxxx>
References: <201101311642.p0VGgXTS018851@xxxxxxxxxxxxxxxxxxxxxx> <4D482E21.5040803@xxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Feb 01, 2011 at 11:00:33AM -0500, Mark Lord wrote:
> On 11-01-31 11:42 AM, Alex Elder wrote:
> > Linus, please accept the following updates for XFS, for 2.6.38-rc3
> > (if it's not too late) or 2.6.38-rc4.
> > 
> > They are all fixes for bugs that have some pretty undesirable
> > consequences.  They address:
> > - One spot in which a hang can occur due to neglecting to drop a
> >   lock
> > - A bug which in some cases a bogus block number can be recorded in
> >   a block map btree, resulting in a subsequent BUG_ON().
> > - Two memory leaks
> > - Three places in which extent sizes are allowed to exceed various
> >   size limits
> > - One place where code depends on behavior that is not well-defined
> >   by the C standard
> > - One problem in handling transaction commit errors
> 
> 
> Are these bugs all new in 2.6.38, or should some of these fixes
> also go out to -stable for earlier revisions?
> 
> 
> > Dave Chinner (8):
> >       xfs: fix log ticket leak on forced shutdown.
> >       xfs: fix efi item leak on forced shutdown

Been there for years, extremely hard to hit, so no.

> >       xfs: speculative delayed allocation uses rounddown_power_of_2 badly

-38-rc1 regression, so no.

> >       xfs: limit extent length for allocation to AG size
> >       xfs: prevent extsize alignment from exceeding maximum extent size
> >       xfs: limit extsize to size of AGs and/or MAXEXTLEN

Been there for years in little used functionality, so no.

> >       xfs: handle CIl transaction commit failures correctly

Introduced with new code in 2.6.35, hard to hit, only results in
small memory leaks, so no.

> >       xfs: fix dquot shaker deadlock

That's a regression, so maybe.

> > bpm@xxxxxxx (1):
> >       xfs: xfs_bmap_add_extent_delay_real should init br_startblock

Been there for years, no evidence ATM that this code path can be
exercised with a mainline kernel, so no.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>