xfs
[Top] [All Lists]

Re: [PATCH 2/4] xfstests: add test to reproduce bmap btree corruption.

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 2/4] xfstests: add test to reproduce bmap btree corruption.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 2 Feb 2011 13:17:41 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1296610194.2350.159.camel@doink>
References: <1295927937-20634-1-git-send-email-david@xxxxxxxxxxxxx> <1295927937-20634-3-git-send-email-david@xxxxxxxxxxxxx> <1296610194.2350.159.camel@doink>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Feb 01, 2011 at 07:29:54PM -0600, Alex Elder wrote:
> On Tue, 2011-01-25 at 14:58 +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > The problem was reprted here:
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=626244
> > 
> > With the simple test case:
> > 
> > # mkfs.xfs -f -d agsize=16m,size=50g <dev>
> > # mount <dev> /mnt
> > # xfs_io -f -c 'resvsp 0 40G' /mnt/foo
> > 
> > Triggering the problem. Turn this into a new xfsqa test so that we
> > exercise the problem code and prevent future regressions.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> This looks good, HOWEVER, since the test crashes
> the target system please remove it from (at least)
> the "auto" group before you commit.

If causes an assert failure on a DEBUG kernel, a shutdown on a
non-debug kernel. Either way, I'd prefer to leave it enabled as a
good reminder that we need to fix the damn bug (*) sooner rather
than later...

(*) This patch prevents the assert failure, but, like Lachlan, I'm
not sure it is the right fix.

http://oss.sgi.com/archives/xfs/2010-09/msg00337.html

I'm working on it at the moment, along with all the other allocation
things...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>