xfs
[Top] [All Lists]

Re: [PATCH 3/4] xfstests: make 016 work with delaylog

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/4] xfstests: make 016 work with delaylog
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 01 Feb 2011 19:30:02 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1295927937-20634-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1295927937-20634-1-git-send-email-david@xxxxxxxxxxxxx> <1295927937-20634-4-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2011-01-25 at 14:58 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Test 016 fails with delaylog because it measures log traffic to disk
> and delaylog writes almost nothing to the log for the given test. TO
> make it work, add sync calls to the work loop to cause the log to be
> flushed reliably for both delaylog and nodelaylog and hence contain
> the same nuumber of log records.
> 
> As a result, the log space consumed by the test is not changed by
> the delaylog option and the test passes. The test is not
> significantly slowed down by the addition of the sync calls (takes
> 15s to run on a single SATA drive).
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 3/4] xfstests: make 016 work with delaylog, Alex Elder <=