xfs
[Top] [All Lists]

Re: [PATCH] Xfstests: make 014 only run on xfs

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] Xfstests: make 014 only run on xfs
From: Josef Bacik <josef@xxxxxxxxxx>
Date: Tue, 1 Feb 2011 19:58:49 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1296604137.2350.138.camel@doink>
References: <1296050729-17316-1-git-send-email-josef@xxxxxxxxxx> <20110127005945.GE21311@dastard> <1296604137.2350.138.camel@doink>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Feb 01, 2011 at 05:48:57PM -0600, Alex Elder wrote:
> On Thu, 2011-01-27 at 11:59 +1100, Dave Chinner wrote:
> > On Wed, Jan 26, 2011 at 09:05:29AM -0500, Josef Bacik wrote:
> > > This test relies on mounting with -o allocsize, which is an xfs specific 
> > > mount
> > > option, so make the test only work on xfs.  Thanks,
> > 
> > Oh, sorry, my fault. Perhaps something like this instead?
> 
> Since test 014 reportedly works on other filesystem
> types provided the allocsize option isn't provided,
> Dave's version looks better.
> 
> Josef will you please take a look over--and preferably
> test--what Dave proposed, and if you agree offer your
> signoff?
>

Yup looks reasonable and runs fine on btrfs.  You can add

Signed-off-by: Josef Bacik <josef@xxxxxxxxxx>

Thanks,

Josef 

<Prev in Thread] Current Thread [Next in Thread>