| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/6] xfs: factor agf counter updates into a helper |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 1 Feb 2011 19:46:50 -0500 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20110125043003.GJ11040@dastard> |
| References: | <20110121092227.115815324@xxxxxxxxxxxxxxxxxxxxxx> <20110121092550.694829728@xxxxxxxxxxxxxxxxxxxxxx> <20110125043003.GJ11040@dastard> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Jan 25, 2011 at 03:30:03PM +1100, Dave Chinner wrote: > Perhaps catching the error here and adding an ASSERT(error == 0) > would be a good idea. I'd rather do an WANT_CORRUPTED_GOTO or equivalent, given that we're dealing with an on-disk corruption here. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: XFS Preallocation, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] Xfstests: make 014 only run on xfs, Josef Bacik |
| Previous by Thread: | Re: [PATCH] Xfstests: make 014 only run on xfs, Alex Elder |
| Next by Thread: | Re: [PATCH 1/4] xfstests: add simple splice test, Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |