[Top] [All Lists]

Re: [PATCH] Xfstests: make 014 only run on xfs

To: Josef Bacik <josef@xxxxxxxxxx>
Subject: Re: [PATCH] Xfstests: make 014 only run on xfs
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 27 Jan 2011 11:59:45 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1296050729-17316-1-git-send-email-josef@xxxxxxxxxx>
References: <1296050729-17316-1-git-send-email-josef@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Jan 26, 2011 at 09:05:29AM -0500, Josef Bacik wrote:
> This test relies on mounting with -o allocsize, which is an xfs specific mount
> option, so make the test only work on xfs.  Thanks,

Oh, sorry, my fault. Perhaps something like this instead?


Dave Chinner

xfstests: conditionalise allocsize option in 014

allocsize is an XFS specific mount option, and hence causes the test
to fail on other filesystems. Only set the mount option on xfs

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
 014 |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/014 b/014
index e6e0a6f..057e4d9 100755
--- a/014
+++ b/014
@@ -53,8 +53,10 @@ _setup_testdir
 # ensure EOF preallocation doesn't massively extend the runtime of this test
 # by limiting the amount of preallocation and therefore the amount of blocks
 # zeroed during the truncfile test run.
-umount $TEST_DIR
-_test_mount -o allocsize=64k
+if [ "$FSTYP" == "xfs" ]; then
+       umount $TEST_DIR
+       _test_mount -o allocsize=64k
 echo "brevity is wit..."

<Prev in Thread] Current Thread [Next in Thread>