xfs
[Top] [All Lists]

Re: [PATCH 7/8] xfs: handle CIl transaction commit failures correctly

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 7/8] xfs: handle CIl transaction commit failures correctly
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 26 Jan 2011 15:23:09 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1295945444-29488-8-git-send-email-david@xxxxxxxxxxxxx>
References: <1295945444-29488-1-git-send-email-david@xxxxxxxxxxxxx> <1295945444-29488-8-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2011-01-25 at 19:50 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Failure to commit a transaction into the CIL is not handled
> correctly. This currently can only happen when racing with a
> shutdown and requires an explicit shutdown check, so it rare and can
> be avoided. Remove the shutdown check and make the CIL commit a void
> function to indicate it will always succeed, thereby removing the
> incorrectly handled failure case.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>