xfs
[Top] [All Lists]

Re: [PATCH 1/8] xfs: fix log ticket leak on forced shutdown.

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/8] xfs: fix log ticket leak on forced shutdown.
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 26 Jan 2011 15:22:22 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1295945444-29488-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1295945444-29488-1-git-send-email-david@xxxxxxxxxxxxx> <1295945444-29488-2-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2011-01-25 at 19:50 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The kmemleak detector shows this after test 139:
> 
> unreferenced object 0xffff880079b88bb0 (size 264):

. . .

>     [<ffffffff81123117>] generic_writepages+0x27/0x30
>     [<ffffffff814aba5d>] xfs_vm_writepages+0x5d/0x80
> 
> By inspection, the leak occurs when xlog_write() returns and error
> and we jump to the abort path without dropping the reference on the
> active ticket.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>