[Top] [All Lists]

Re: [PATCH 4/4] xfstests: Speed up test 042

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] xfstests: Speed up test 042
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 26 Jan 2011 15:35:47 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1295927937-20634-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1295927937-20634-1-git-send-email-david@xxxxxxxxxxxxx> <1295927937-20634-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jan 25, 2011 at 02:58:57PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> test 042 generates a worst-case fragmented filesystem and uses it to
> test xfs_fsr. It uses small 4k files to generate the hole-space-hole
> pattern that fragments free space badly. It is much faster to
> generate the same pattern by creating a single large file and
> punching holes in it.  Also, instead of writing large files to
> create unfragmented space, just use preallocation so we don't have
> to write the data to disk.
> These changes reduce the runtime of the test on a single SATA drive
> from 106s to 27s.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>