xfs
[Top] [All Lists]

Re: [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 25 Jan 2011 10:47:41 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110124084732.GA4378@xxxxxxxxxxxxx>
References: <1294649091-27174-1-git-send-email-david@xxxxxxxxxxxxx> <1294649091-27174-3-git-send-email-david@xxxxxxxxxxxxx> <20110124084732.GA4378@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Jan 24, 2011 at 03:47:32AM -0500, Christoph Hellwig wrote:
> > +typedef    int32_t atomic_t;
> > +typedef    int64_t atomic64_t;
> > +
> > +#define atomic_inc_return(x)       (++(*(x)))
> > +#define atomic_dec_return(x)       (--(*(x)))
> > +
> > +#define atomic64_read(x)   *(x)
> > +#define atomic64_set(x, v) (*(x) = v)
> 
> These defintions are pretty dangerous if we ever happens to use
> them in multi-threaded code like repair.   Currently we're not,
> but they should grow a larger warning comment.

Ok, I'll add a warning to that effect.

> > --- /dev/null
> > +++ b/include/hlist.h
> 
> Why not add the hlist helpers to list.h, like in the kernel tree?

It was just a side effect of the process I followed to add the bits
of missing functionality that were needed. I can add it to list.h if
you want, but I don't think it really matters either way...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>