xfs
[Top] [All Lists]

Re: [PATCH 2/5] xfs: limit extent length for allocation to AG size

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/5] xfs: limit extent length for allocation to AG size
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 25 Jan 2011 10:31:02 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110124090252.GC26744@xxxxxxxxxxxxx>
References: <1295411400-15614-1-git-send-email-david@xxxxxxxxxxxxx> <1295411400-15614-3-git-send-email-david@xxxxxxxxxxxxx> <20110124090252.GC26744@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Jan 24, 2011 at 04:02:52AM -0500, Christoph Hellwig wrote:
> > +   /*
> > +    * The requested extent can be larger than an AG, so trim the block
> > +    * count back to the maximum sized extent in an AG. A typical empty AG
> > +    * consumes 1 block for headers, 1 block for each btree root (3) and 4
> > +    * blocks for the free list.
> > +    */
> > +   args.maxlen = MIN(ap->alen, mp->m_sb.sb_agblocks - 8);
> 
> Maybe add a define for the over head blocks to document it more clearly?
> 

Will do.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>