xfs
[Top] [All Lists]

Re: [PATCH 3/5] xfs: prevent extsize alignment from exceeding maximum ex

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/5] xfs: prevent extsize alignment from exceeding maximum extent size
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 24 Jan 2011 04:04:59 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1295411400-15614-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1295411400-15614-1-git-send-email-david@xxxxxxxxxxxxx> <1295411400-15614-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +                                     /*
> +                                      * make sure we don't exceed a single
> +                                      * extent length when we align the
> +                                      * extent by reducing length we are
> +                                      * going to allocate by the maximum
> +                                      * amount extent size aligment may
> +                                      * require.
> +                                     alen = (xfs_extlen_t)XFS_FILBLKS_MIN(
> +                                                     len,
> +                                             MAXEXTLEN - (2 * extsz - 1));
> +                                      */

This essentially just adds a comment, given that the new code is inside
the bracing.  Also the xfs_extlen_t cast seems pointless.  The C type
promotion rules do just fine for going down from a 64bit type to a 32bit
one, as long as the results fit into the latter - which they always do
here.

<Prev in Thread] Current Thread [Next in Thread>