| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/5] xfs: limit extent length for allocation to AG size |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 24 Jan 2011 04:02:52 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1295411400-15614-3-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1295411400-15614-1-git-send-email-david@xxxxxxxxxxxxx> <1295411400-15614-3-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> + /* > + * The requested extent can be larger than an AG, so trim the block > + * count back to the maximum sized extent in an AG. A typical empty AG > + * consumes 1 block for headers, 1 block for each btree root (3) and 4 > + * blocks for the free list. > + */ > + args.maxlen = MIN(ap->alen, mp->m_sb.sb_agblocks - 8); Maybe add a define for the over head blocks to document it more clearly? Otherwise looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/5] xfs: speculative delayed allocation uses rounddown_power_of_2 badly, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 3/5] xfs: prevent extsize alignment from exceeding maximum extent size, Christoph Hellwig |
| Previous by Thread: | [PATCH 2/5] xfs: limit extent length for allocation to AG size, Dave Chinner |
| Next by Thread: | Re: [PATCH 2/5] xfs: limit extent length for allocation to AG size, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |