xfs
[Top] [All Lists]

Re: [PATCH 1/5] xfs: speculative delayed allocation uses rounddown_power

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] xfs: speculative delayed allocation uses rounddown_power_of_2 badly
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 24 Jan 2011 03:59:49 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1295411400-15614-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1295411400-15614-1-git-send-email-david@xxxxxxxxxxxxx> <1295411400-15614-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jan 19, 2011 at 03:29:56PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> rounddown_power_of_2() returns an undefined result when passed a
> value of zero. The specualtive delayed allocation code is doing this
> when the inode is zero length. Hence occasionally the preallocation
> is much, mcuh large than is necessary (e.g. 8GB for a 270 _byte_

        ^^^^^^^^^ typo

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>