xfs
[Top] [All Lists]

Re: [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 24 Jan 2011 03:47:32 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1294649091-27174-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1294649091-27174-1-git-send-email-david@xxxxxxxxxxxxx> <1294649091-27174-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +typedef      int32_t atomic_t;
> +typedef      int64_t atomic64_t;
> +
> +#define atomic_inc_return(x) (++(*(x)))
> +#define atomic_dec_return(x) (--(*(x)))
> +
> +#define atomic64_read(x)     *(x)
> +#define atomic64_set(x, v)   (*(x) = v)

These defintions are pretty dangerous if we ever happens to use
them in multi-threaded code like repair.   Currently we're not,
but they should grow a larger warning comment.

> --- /dev/null
> +++ b/include/hlist.h

Why not add the hlist helpers to list.h, like in the kernel tree?

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>