xfs
[Top] [All Lists]

Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 19 Jan 2011 06:39:01 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20110118214610.GW28803@dastard>
References: <1294792553-8378-1-git-send-email-david@xxxxxxxxxxxxx> <1294792553-8378-8-git-send-email-david@xxxxxxxxxxxxx> <20110118130023.GA23988@xxxxxxxxxxxxx> <20110118214610.GW28803@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jan 19, 2011 at 08:46:10AM +1100, Dave Chinner wrote:
> > I would be nice to just move the quite flag into the normal mount flags
> > and have a xfs_mount_warn that checks it based off the mp.
> 
> Given it is a flag that is only relevant for the mount context, is
> there really any need to use a flag that persists for the entire
> life of the filesystem for it? I don't think the code is that hard
> to follow right now. ;)

We can clear the flag after the mount.  But in the end it's probably
not worth bothering, so feel free to leave it as-is.

<Prev in Thread] Current Thread [Next in Thread>