xfs
[Top] [All Lists]

Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 19 Jan 2011 08:48:50 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110118130314.GC23988@xxxxxxxxxxxxx>
References: <1294792553-8378-1-git-send-email-david@xxxxxxxxxxxxx> <20110118130314.GC23988@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Jan 18, 2011 at 08:03:14AM -0500, Christoph Hellwig wrote:
> The series looks good to me.  One thing that feels a bit odd is
> the xfs_printk.[ch] name - the functions exported to the rest of the
> code don't contain prink anyway.  Maybe xfs_msg.[ch] or
> xfs_message.[ch]?

I was struggling for something relevant to call the file -
xfs_message.[ch] definitely seems more appropriate. I'll change
the name..

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>