Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 19 Jan 2011 08:46:10 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20110118130023.GA23988@xxxxxxxxxxxxx>
References:	<1294792553-8378-1-git-send-email-david@xxxxxxxxxxxxx> <1294792553-8378-8-git-send-email-david@xxxxxxxxxxxxx> <20110118130023.GA23988@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Tue, Jan 18, 2011 at 08:00:23AM -0500, Christoph Hellwig wrote:
> On Wed, Jan 12, 2011 at 11:35:48AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > The xfs_fs_mount_cmn_err() hide a simple check as to whether the
> > mount path should output an error or not. Remove the macro and open
> > code the check.
> 
> I would be nice to just move the quite flag into the normal mount flags
> and have a xfs_mount_warn that checks it based off the mp.

Given it is a flag that is only relevant for the mount context, is
there really any need to use a flag that persists for the entire
life of the filesystem for it? I don't think the code is that hard
to follow right now. ;)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 10/12] xfs: convert the quota debug prints to new API, (continued) [PATCH 10/12] xfs: convert the quota debug prints to new API, Dave Chinner [PATCH 12/12] xfs: kill support/debug.[ch], Dave Chinner Re: [PATCH 12/12] xfs: kill support/debug.[ch], Alex Elder Re: [PATCH 12/12] xfs: kill support/debug.[ch], Christoph Hellwig [PATCH 02/12] xfs: introduce new logging API., Dave Chinner [PATCH 08/12] xfs: convert xfs_fs_cmn_err to new error logging API, Dave Chinner [PATCH 11/12] xfs: Convert remaining cmn_err() callers to new API, Dave Chinner [PATCH 09/12] xfs: rename xfs_cmn_err_fsblock_zero(), Dave Chinner [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro, Dave Chinner Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro, Christoph Hellwig Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro, Dave Chinner <= Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro, Christoph Hellwig [PATCH 05/12] xfs: convert xfs_cmn_err to xfs_alert_tag, Dave Chinner [PATCH 06/12] xfs: kill xfs_fs_repair_cmn_err() macro, Dave Chinner [PATCH 01/12] xfs: prevent NMI timeouts in cmn_err, Dave Chinner Re: [PATCH 01/12] xfs: prevent NMI timeouts in cmn_err, Alex Elder Re: [PATCH 01/12] xfs: prevent NMI timeouts in cmn_err, Christoph Hellwig Re: [PATCH 01/12] xfs: prevent NMI timeouts in cmn_err, Dave Chinner XFS master branch update, Alex Elder [PATCH 03/12] xfs: Convert linux-2.6/ files to new logging interface, Dave Chinner Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure, Alex Elder

Previous by Date:	Re: [PATCH] xfsprogs: add fpunch command for hole punching via fallocate, Dave Chinner
Next by Date:	Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure, Dave Chinner
Previous by Thread:	Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro, Christoph Hellwig
Next by Thread:	Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro