xfs
[Top] [All Lists]

Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [RFC, PATCH 0/12] xfs: rework error logging infrastructure
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 18 Jan 2011 08:03:14 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1294792553-8378-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1294792553-8378-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
The series looks good to me.  One thing that feels a bit odd is
the xfs_printk.[ch] name - the functions exported to the rest of the
code don't contain prink anyway.  Maybe xfs_msg.[ch] or
xfs_message.[ch]?

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

for the whole series.

<Prev in Thread] Current Thread [Next in Thread>