xfs
[Top] [All Lists]

Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 18 Jan 2011 08:00:23 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1294792553-8378-8-git-send-email-david@xxxxxxxxxxxxx>
References: <1294792553-8378-1-git-send-email-david@xxxxxxxxxxxxx> <1294792553-8378-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jan 12, 2011 at 11:35:48AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The xfs_fs_mount_cmn_err() hide a simple check as to whether the
> mount path should output an error or not. Remove the macro and open
> code the check.

I would be nice to just move the quite flag into the normal mount flags
and have a xfs_mount_warn that checks it based off the mp.

<Prev in Thread] Current Thread [Next in Thread>