[Top] [All Lists]

Re: [PATCH] Xfsprogs: add fiemap command to xfs_io

To: Josef Bacik <josef@xxxxxxxxxx>
Subject: Re: [PATCH] Xfsprogs: add fiemap command to xfs_io
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 18 Jan 2011 07:49:04 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1295009501-17794-1-git-send-email-josef@xxxxxxxxxx>
References: <1295009501-17794-1-git-send-email-josef@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jan 14, 2011 at 07:51:41AM -0500, Josef Bacik wrote:
> When trying to add a test for hole punching I noticed that the "bmap" command
> only works on XFS, which makes testing hole punching on other fs's kind of
> difficult.  To fix this I've added an fiemap command that works almost exactly
> like bmap.  It is formatted similarly and takes similar flags, the only thing
> thats different is obviously it doesn't spit out AG info and it doesn't make
> finding prealloc space optional.  This is my first foray into all of this 
> stuff
> so a good hard look would be appreciated.  I tested it with a few different
> files to make sure bmap and fiemap both looked the same.  Thanks,

Looks good to me.

<Prev in Thread] Current Thread [Next in Thread>