xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: fix log ticket leak on forced shutdown.

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: fix log ticket leak on forced shutdown.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 18 Jan 2011 07:35:16 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1295010430-12495-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1295010430-12495-1-git-send-email-david@xxxxxxxxxxxxx> <1295010430-12495-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> By inspection, the leak occurs when xlog_write() returns and error
> and we jump to the abort path without dropping the reference on the
> active ticket.

Indeed,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>