xfs
[Top] [All Lists]

Re: [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 11 Jan 2011 15:44:14 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1294702668-15216-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1294702668-15216-1-git-send-email-david@xxxxxxxxxxxxx> <1294702668-15216-6-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2011-01-11 at 10:37 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The current xfs_file_aio_write code is a mess of locking shenanigans
> to handle the different locking requirements of buffered and direct
> IO. Start to clean this up by disentangling the direct IO path from
> the mess.
> 
> This also removes the failed direct IO fallback path to buffered IO.
> XFS handles all direct IO cases without needing to fall back to
> buffered IO, so we can safely remove this unused path. This greatly
> simplifies the logic and locking needed in the write path.

I reviewed this before, and your statement here
now explains the important change you made about
the dead code for falling back to buffered I/O.

So:

Reviewed-by: Alex Elder <aelder@xxxxxxx>

I think Christoph and I have signed off on all eight
of the patches in this series now.

                                        -Alex

> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> ---

<Prev in Thread] Current Thread [Next in Thread>