xfs
[Top] [All Lists]

Re: [PATCH] xfstests: add simple splice test

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: add simple splice test
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 11 Jan 2011 12:38:45 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1294702344-15035-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1294702344-15035-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +echo "Feel the serenity."
> +
> +SRC=$TEST_DIR/$seq.src
> +DST=$TEST_DIR/$seq.dst
> +
> +$XFS_IO_PROG -f -c "pwrite -S 0xa5a55a5a 0 32768k" -c fsync $SRC > /dev/null 
> 2>&1
> +$XFS_IO_PROG -f -c "sendfile -i $SRC 0 32768k" -c fsync $DST > /dev/null 2>&1
> +
> +diff $SRC $DST

I think this should removfe the two files to make sure the test is
reproducible and doesn't overwrite an existing file during the second
run.  Also I'd recomment not to redirect the output to /dev/null but use
our normal xfs_io filters and make the output part of the golden output.

<Prev in Thread] Current Thread [Next in Thread>