xfs
[Top] [All Lists]

Re: [PATCH 4/8] xfs: introduce xfs_rw_lock() helpers for locking the ino

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/8] xfs: introduce xfs_rw_lock() helpers for locking the inode
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 11 Jan 2011 09:26:18 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110110192305.GF25029@xxxxxxxxxxxxx>
References: <1294399825-1157-1-git-send-email-david@xxxxxxxxxxxxx> <1294399825-1157-5-git-send-email-david@xxxxxxxxxxxxx> <20110110192305.GF25029@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Jan 10, 2011 at 02:23:05PM -0500, Christoph Hellwig wrote:
> > -   xfs_ilock(ip, XFS_IOLOCK_EXCL);
> > +   xfs_rw_ilock(ip, XFS_ILOCK_EXCL|XFS_IOLOCK_EXCL);
> 
> this now takes i_mutex, which will be taken again by
> generic_file_splice_write.

Ah, oops. I'll revert that bit - I thought we had test coverage of
that interface. I guess we need a basic sanity test for this
functionality. I'll write one.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>