Re: [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 10 Jan 2011 14:24:44 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1294399825-1157-6-git-send-email-david@xxxxxxxxxxxxx>
References:	<1294399825-1157-1-git-send-email-david@xxxxxxxxxxxxx> <1294399825-1157-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

> +     xfs_rw_ilock(ip, XFS_ILOCK_EXCL|*iolock);

care to use normal spaces before/after operators? (also in a few other
places)

Otherwise looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/8] xfs: prevent corruption due to overlapping AIO DIO V3, Dave Chinner [PATCH 1/8] xfs: ensure sync write errors are returned, Dave Chinner Re: [PATCH 1/8] xfs: ensure sync write errors are returned, Christoph Hellwig [PATCH 4/8] xfs: introduce xfs_rw_lock() helpers for locking the inode, Dave Chinner Re: [PATCH 4/8] xfs: introduce xfs_rw_lock() helpers for locking the inode, Christoph Hellwig Re: [PATCH 4/8] xfs: introduce xfs_rw_lock() helpers for locking the inode, Dave Chinner [PATCH 2/8] xfs: factor common post-write isize handling code, Dave Chinner Re: [PATCH 2/8] xfs: factor common post-write isize handling code, Christoph Hellwig [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write, Dave Chinner Re: [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write, Christoph Hellwig <= [PATCH 3/8] xfs: factor post-write newsize updates, Dave Chinner Re: [PATCH 3/8] xfs: factor post-write newsize updates, Christoph Hellwig [PATCH 8/8] xfs: serialise unaligned direct IOs, Dave Chinner Re: [PATCH 8/8] xfs: serialise unaligned direct IOs, Christoph Hellwig [PATCH 6/8] xfs: split buffered IO write path from xfs_file_aio_write, Dave Chinner Re: [PATCH 6/8] xfs: split buffered IO write path from xfs_file_aio_write, Christoph Hellwig [PATCH 7/8] xfs: factor common write setup code, Dave Chinner Re: [PATCH 7/8] xfs: factor common write setup code, Christoph Hellwig

Previous by Date:	Re: [PATCH 4/8] xfs: introduce xfs_rw_lock() helpers for locking the inode, Christoph Hellwig
Next by Date:	Re: [PATCH 6/8] xfs: split buffered IO write path from xfs_file_aio_write, Christoph Hellwig
Previous by Thread:	[PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write, Dave Chinner
Next by Thread:	[PATCH 3/8] xfs: factor post-write newsize updates, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write