xfs
[Top] [All Lists]

Re: [PATCH 1/8] xfs: ensure sync write errors are returned

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/8] xfs: ensure sync write errors are returned
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 7 Jan 2011 20:07:29 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110107084518.GA10829@xxxxxxxxxxxxx>
References: <1294116518-14908-1-git-send-email-david@xxxxxxxxxxxxx> <1294116518-14908-2-git-send-email-david@xxxxxxxxxxxxx> <20110107084518.GA10829@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jan 07, 2011 at 03:45:18AM -0500, Christoph Hellwig wrote:
> > +           if (ret == -ENOSPC && !enospc) {
> > +                   ssize_t ret2 = xfs_flush_pages(ip, 0, -1, 0, FI_NONE);
> > +                   if (ret2) {
> > +                           ret = ret2;
> >                             goto out_unlock_internal;
> > +                   }
> >                     enospc = 1;
> >                     goto write_retry;
> >             }
> 
> I don't think there is any reason for the ret2 variale here.  If it's
> non-zero we assign it to ret, and if it's zero we overwrite it again
> after jumping to the write_retry label.

True, I'll fix it.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>