xfs
[Top] [All Lists]

Re: [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 7 Jan 2011 03:58:30 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1294116518-14908-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1294116518-14908-1-git-send-email-david@xxxxxxxxxxxxx> <1294116518-14908-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +This also clearly indicates that XFS
> + * does not fall back to buffered IO in the direct IO write path.

I don't think this comment belongs into the function header.  It's
already present in the right place anyway, so it can just be removed.

> +     xfs_buftarg_t           *target = XFS_IS_REALTIME_INODE(ip) ?
> +                                     mp->m_rtdev_targp : mp->m_ddev_targp;

struct xfs_buftarg, please.

> +     trace_xfs_file_direct_write(ip, count, iocb->ki_pos, 0);
> +     ret = generic_file_direct_write(iocb, iovp,
> +                     &nr_segs, pos, &iocb->ki_pos, count, ocount);
> +
> +     /* No fallback to buffered IO on errors for XFS. */
> +     return ret;

I'd add an

        ASSERT(ret < 0 || ret == count);

here to make sure we don't get problems due to changes in the core
direct I/O code.

<Prev in Thread] Current Thread [Next in Thread>