xfs
[Top] [All Lists]

Re: [PATCH 7/8] xfs: factor common write setup code

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 7/8] xfs: factor common write setup code
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 7 Jan 2011 03:53:57 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1294116518-14908-8-git-send-email-david@xxxxxxxxxxxxx>
References: <1294116518-14908-1-git-send-email-david@xxxxxxxxxxxxx> <1294116518-14908-8-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jan 04, 2011 at 03:48:37PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The buffered IO and direct Io write paths share a common set of
> checks and limiting code prior to issuing the write. Factor that
> into a common helper function.

Wouldn't it be better to create the helper before duplicating the code,
aka move it before the buffer/direct splits in the series?

> +     /*
> +      * If we're writing the file then make sure to clear the setuid and
> +      * setgid bits if the process is not being run by root.  This keeps
> +      * people from modifying setuid and setgid binaries.
> +      */
> +     error = file_remove_suid(file);
> +     return error;

just

        return file_remove_suid(file);
?

<Prev in Thread] Current Thread [Next in Thread>