xfs
[Top] [All Lists]

Re: [PATCH] xfs: add FITRIM support

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfs: add FITRIM support
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 6 Jan 2011 13:03:05 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1294178115.2485.19.camel@doink>
References: <20110102072202.GA26488@xxxxxxxxxxxxx> <1294178115.2485.19.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
> > + * Copyright (C) 2010 Red Hat, Inc.
> 
> Maybe 2011 now...

Nothing major changes in 2011, so no.

> > +            * If the extent is entirely outside of the range we are
> > +            * supposed to discard skip it.  Do not bother to trim
> > +            * down partially overlapping ranges for now.
> > +            */
> > +           if (XFS_AGB_TO_FSB(mp, agno, fbno) + flen < start ||
> > +               XFS_AGB_TO_FSB(mp, agno, fbno) > start + len) {
> 
>                                                     ^
>                                           I think this should be >=

Yes.

> Do you want to add a boilerplate copyright header here?

Kinda hard to claim copyright on a single prototype.

<Prev in Thread] Current Thread [Next in Thread>