[Top] [All Lists]

Re: [PATCH] xfs: ensure log covering transactions are synchronous

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: ensure log covering transactions are synchronous
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 04 Jan 2011 20:01:46 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1294116569-15052-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1294116569-15052-1-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2011-01-04 at 15:49 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> To ensure the log is covered and the filesystem idles correctly, we
> need to ensure that dummy transactions hit the disk and do not stay
> pinned in memory.  If the superblock is pinned in memory, it can't
> be flushed so the log covering cannot make progress. The result is
> dependent on timing - more oftent han not we continue to issues a
> log covering transaction every 36s rather than idling after ~90s.
> Fix this by making the log covering transaction synchronous. To
> avoid additional log force from xfssyncd, make the log covering
> transaction take the place of the existing log force in the xfssyncd
> background sync process.

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---

<Prev in Thread] Current Thread [Next in Thread>