[Top] [All Lists]

Re: [PATCH] xfs: add FITRIM support

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: add FITRIM support
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 4 Jan 2011 11:15:18 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110102072202.GA26488@xxxxxxxxxxxxx>
References: <20110102072202.GA26488@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Sun, Jan 02, 2011 at 02:22:02AM -0500, Christoph Hellwig wrote:
> Allow manual discards from userspace using the FITRIM ioctl.  This is not
> intended to be run during normal workloads, as the freepsace btree walks
> can cause large performance degradation.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> V1 -> V2
>  - added __user annotations as noted by Alex
>  - removed non-blocking agf read as noted by Alex
>  - update range->len as noted by Alex
> This does not implement the by-bno search or lock break suggestions from
> Dave.  Given that the 2.6.38 window is about to close those seem a bit
> risky to me.  I'll look into these later.

Ok, seemms like a good way to proceed.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>