xfs
[Top] [All Lists]

Re: [PATCH] xfs: use KM_NOFS for allocations during attribute list opera

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: use KM_NOFS for allocations during attribute list operations
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 29 Dec 2010 07:54:00 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1292892993-12424-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1292892993-12424-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 21, 2010 at 11:56:33AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When listing attributes, we are doiing memory allocations under the
> inode ilock using only KM_SLEEP. This allows memory allocation to
> recurse back into the filesystem and do writeback, which may the
> ilock we already hold on the current inode. THis will deadlock.
> Hence use KM_NOFS for such allocations outside of transaction
> context to ensure that reclaim recursion does not occur.
> 
> Reported-by: Nick Piggin <npiggin@xxxxxxxxx>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>