xfs
[Top] [All Lists]

Re: [PATCH 4/4] xfs: untangle phase1 vs phase2 recovery helpers

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] xfs: untangle phase1 vs phase2 recovery helpers
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 23 Dec 2010 13:06:23 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101201220710.647499265@xxxxxxxxxxxxxxxxxxxxxx>
References: <20101201220620.340188389@xxxxxxxxxxxxxxxxxxxxxx> <20101201220710.647499265@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Dec 01, 2010 at 05:06:24PM -0500, Christoph Hellwig wrote:
> Dispatch to a different helper for phase1 vs phase2 in 
> xlog_recover_commit_trans
> instead of doing it in all the low-level functions.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Good cleanup. That'll make it much easier to work out how to
shoe-horn in item readahead to try to minimise log recovery times
for large logs...

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>