| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/4] xfs: refactor xlog_recover_commit_trans |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 23 Dec 2010 12:56:33 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20101201220710.454838485@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20101201220620.340188389@xxxxxxxxxxxxxxxxxxxxxx> <20101201220710.454838485@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Wed, Dec 01, 2010 at 05:06:23PM -0500, Christoph Hellwig wrote: > Merge the call to xlog_recover_reorder_trans and the loop over the > recovery items from xlog_recover_do_trans into xlog_recover_commit_trans, > and keep the switch statement over the log item types as a separate helper. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Much nicer. With the small "break" fix Alex commented on, it looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/4] xfs: use struct list_head for the buf cancel table, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 4/4] xfs: untangle phase1 vs phase2 recovery helpers, Dave Chinner |
| Previous by Thread: | Re: [PATCH 3/4] xfs: refactor xlog_recover_commit_trans, Christoph Hellwig |
| Next by Thread: | [PATCH 2/4] xfs: use struct list_head for the buf cancel table, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |