xfs
[Top] [All Lists]

Re: [PATCH 1/4] xfs: remove leftovers of old buffer log items in recover

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/4] xfs: remove leftovers of old buffer log items in recovery code
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 23 Dec 2010 12:50:40 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20101201220710.042656730@xxxxxxxxxxxxxxxxxxxxxx>
References: <20101201220620.340188389@xxxxxxxxxxxxxxxxxxxxxx> <20101201220710.042656730@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Dec 01, 2010 at 05:06:21PM -0500, Christoph Hellwig wrote:
> XFS used to support different types of buffer log items long time ago.
> Remove the switch statements checking the log item type in various
> buffer recovery helpers that were left over from those days and the
> rather useless xlog_recover_do_buffer_pass2 wrapper.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good. This should have been done when all the old unsupported
buffer formats were removed.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>


-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>