| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: xfs_efi_item slab leak |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 21 Dec 2010 11:54:05 +1100 |
| Cc: | Nick Piggin <npiggin@xxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20101220113139.GA10324@xxxxxxxxxxxxx> |
| References: | <AANLkTi=LrU2CsC-VZmJ5M9U7eJpjqfAv8UgaEYv=Sg01@xxxxxxxxxxxxxx> <20101218000245.GG5193@dastard> <20101220113139.GA10324@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Mon, Dec 20, 2010 at 06:31:39AM -0500, Christoph Hellwig wrote: > On Sat, Dec 18, 2010 at 11:02:45AM +1100, Dave Chinner wrote: > > Ok, after unmounting everything I can see two items in remaining in > > the xfs_efi_item cache after an xfstests run. ??t's probably to do > > with a filesystem shutdown not cleaning them up correctly. I'll put > > it on my list of stuff to track down. > > Does it still happen with your working tree? The incorrect handling > of IOP_UNPING with remove == 1 looks like it could cause something > similar. I haven't checked the current patch set - just on the kernel that I was currently running - I'll do more analysis later this afternoon. I agree that the IOP_UNPIN() handling is a likely culprit, though. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/7] xfs: split direct IO write path from xfs_file_aio_write, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner |
| Previous by Thread: | Re: xfs_efi_item slab leak, Christoph Hellwig |
| Next by Thread: | Supply dry porcini, dry shiitake, and dry champignons, CHUN BAO |
| Indexes: | [Date] [Thread] [Top] [All Lists] |