Re: [PATCH 02/12] xfs: fact out common grant head/log tail verification

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 02/12] xfs: fact out common grant head/log tail verification code
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 20 Dec 2010 06:51:25 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1292215483-18224-3-git-send-email-david@xxxxxxxxxxxxx>
References:	<1292215483-18224-1-git-send-email-david@xxxxxxxxxxxxx> <1292215483-18224-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Dec 13, 2010 at 03:44:33PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Factor repeated debug code out of grant head manipulation functions into a
> separate function. This removes ifdef DEBUG spagetti from the code and makes
> the code easier to follow.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
xfs: grant lock scaling and removal V3, Dave Chinner [PATCH 03/12] xfs: rework log grant space calculations, Dave Chinner Re: [PATCH 03/12] xfs: rework log grant space calculations, Christoph Hellwig [PATCH 09/12] xfs: convert log grant heads to atomic variables, Dave Chinner [PATCH 11/12] xfs: convert grant head manipulations to lockless algorithm, Dave Chinner Re: [PATCH 11/12] xfs: convert grant head manipulations to lockless algorithm, Christoph Hellwig [PATCH 10/12] xfs: introduce new locks for the log grant ticket wait queues, Dave Chinner Re: [PATCH 10/12] xfs: introduce new locks for the log grant ticket wait queues, Christoph Hellwig [PATCH 02/12] xfs: fact out common grant head/log tail verification code, Dave Chinner Re: [PATCH 02/12] xfs: fact out common grant head/log tail verification code, Christoph Hellwig <= [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer, Dave Chinner Re: [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer, Christoph Hellwig [PATCH 12/12] xfs: kill useless spinlock_destroy macro, Dave Chinner [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Dave Chinner Re: [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Christoph Hellwig Re: [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Dave Chinner [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Christoph Hellwig Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner [PATCH 06/12] xfs: make AIL tail pushing independent of the grant lock, Dave Chinner

Previous by Date:	Re: [PATCH 11/12] xfs: convert grant head manipulations to lockless algorithm, Christoph Hellwig
Next by Date:	Re: [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Christoph Hellwig
Previous by Thread:	[PATCH 02/12] xfs: fact out common grant head/log tail verification code, Dave Chinner
Next by Thread:	[PATCH 04/12] xfs: combine grant heads into a single 64 bit integer, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]