Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 20 Dec 2010 06:34:58 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1292215483-18224-2-git-send-email-david@xxxxxxxxxxxxx>
References:	<1292215483-18224-1-git-send-email-david@xxxxxxxxxxxxx> <1292215483-18224-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Dec 13, 2010 at 03:44:32PM +1100, Dave Chinner wrote:
> -             __field(void *, reserve_headq)
> -             __field(void *, write_headq)
> +             __field(void *, reserveq)
> +             __field(void *, writeq)

To repeat my question from the last review:  what's the point in logging
this at all?  There's not much we can do with it from trace-cmd / perf
output.  What might be more useful is a list_empty() boolean flag.

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 10/12] xfs: introduce new locks for the log grant ticket wait queues, (continued) Re: [PATCH 10/12] xfs: introduce new locks for the log grant ticket wait queues, Christoph Hellwig [PATCH 02/12] xfs: fact out common grant head/log tail verification code, Dave Chinner Re: [PATCH 02/12] xfs: fact out common grant head/log tail verification code, Christoph Hellwig [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer, Dave Chinner Re: [PATCH 04/12] xfs: combine grant heads into a single 64 bit integer, Christoph Hellwig [PATCH 12/12] xfs: kill useless spinlock_destroy macro, Dave Chinner [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Dave Chinner Re: [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Christoph Hellwig Re: [PATCH 08/12] xfs: convert l_tail_lsn to an atomic variable., Dave Chinner [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Christoph Hellwig <= Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner [PATCH 06/12] xfs: make AIL tail pushing independent of the grant lock, Dave Chinner Re: [PATCH 06/12] xfs: make AIL tail pushing independent of the grant lock, Christoph Hellwig [PATCH 07/12] xfs: convert l_last_sync_lsn to an atomic variable, Dave Chinner [PATCH 05/12] xfs: use wait queues directly for the log wait queues, Dave Chinner Re: [PATCH 05/12] xfs: use wait queues directly for the log wait queues, Christoph Hellwig

Previous by Date:	Re: xfs_efi_item slab leak, Christoph Hellwig
Next by Date:	Re: [PATCH 03/12] xfs: rework log grant space calculations, Christoph Hellwig
Previous by Thread:	[PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner
Next by Thread:	Re: [PATCH 01/12] xfs: convert log grant ticket queues to list heads, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]